linux-kernel - Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Sep 2016 16:04:53 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     <libc-alpha@...rceware.org>,
        Bamvor Jian Zhang <bamvor.zhangjian@...wei.com>,
        <catalin.marinas@....com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <linux-arch@...r.kernel.org>, <schwidefsky@...ibm.com>,
        <heiko.carstens@...ibm.com>, <pinskia@...il.com>,
        <broonie@...nel.org>, <joseph@...esourcery.com>,
        <christoph.muellner@...obroma-systems.com>,
        <szabolcs.nagy@....com>, <klimov.linux@...il.com>,
        <Nathan_Lynch@...tor.com>, <agraf@...e.de>,
        <Prasun.Kapoor@...iumnetworks.com>, <kilobyte@...band.pl>,
        <geert@...ux-m68k.org>, <philipp.tomsich@...obroma-systems.com>,
        <manuel.montezelo@...il.com>, <linyongting@...wei.com>,
        <maxim.kuvyrkov@...aro.org>, <davem@...emloft.net>,
        <zhouchengming1@...wei.com>, <cmetcalf@...hip.com>,
        Andrew Pinski <apinski@...ium.com>,
        Andrew Pinski <Andrew.Pinski@...iumnetworks.com>,
        Hanjun Guo <guohanjun@...wei.com>,
        chenjianguo 00365834 <chenjianguo3@...wei.com>,
        jijun 00321192 <jijun2@...wei.com>
Subject: Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table
 (in entry.S) to use it

On Fri, Sep 02, 2016 at 02:55:34PM +0200, Arnd Bergmann wrote:
> On Friday, September 2, 2016 6:46:19 PM CEST Bamvor Jian Zhang wrote:
> > diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h
> > index 043d17a..78bea1d 100644
> > --- a/arch/arm64/include/uapi/asm/unistd.h
> > +++ b/arch/arm64/include/uapi/asm/unistd.h
> > @@ -16,4 +16,9 @@
> > 
> >  #define __ARCH_WANT_RENAMEAT
> > 
> > +/* We need to make sure it works for both userspace and kernel(sys_ilp32.c) */
> > +#if defined(__ILP32__) || defined(__SYSCALL_COMPAT)
> > +#define __ARCH_WANT_SYNC_FILE_RANGE2
> > +#endif
> > +
> >  #include <asm-generic/unistd.h>
> > diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c
> > index 10fc0ca..13c9c9d 100644
> > --- a/arch/arm64/kernel/sys_ilp32.c
> > +++ b/arch/arm64/kernel/sys_ilp32.c
> > @@ -42,7 +42,7 @@
> >  #define compat_sys_pwrite64            compat_sys_pwrite64_wrapper
> >  #define compat_sys_readahead           compat_sys_readahead_wrapper
> >  #define compat_sys_shmat               sys_shmat
> > -#define compat_sys_sync_file_range     compat_sys_sync_file_range2_wrapper
> > +#define compat_sys_sync_file_range2    compat_sys_sync_file_range2_wrapper
> >  #define compat_sys_truncate64          compat_sys_truncate64_wrapper
> >  #define sys_mmap2                      compat_sys_mmap2_wrapper
> >  #define sys_ptrace                     compat_sys_ptrace
> > 
> 
> Looks good to me.
> 
> 	Arnd

Thank you. I'll take it.

Yury.