linux-kernel - Re: [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecc0ad5e-fc00-752d-be1b-0cf114168508@redhat.com>
Date:   Fri, 2 Sep 2016 15:48:57 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Roman Kagan <rkagan@...tuozzo.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, peterhornyack@...gle.com, rkrcmar@...hat.com,
        den@...nvz.org
Subject: Re: [PATCH 1/4] KVM: x86: always fill in vcpu->arch.hv_clock



On 02/09/2016 15:31, Roman Kagan wrote:
> >  
> > -	if (!vcpu->pv_time_enabled)
> > -		return 0;
> 
> Strictly speaking, you only need .hv_clock updated if either kvmclock or
> tsc_ref_page is enabled, so you may want to still skip the calculations
> otherwise.

Yeah, but that's really a rare case so I don't think it's worth it...

Paolo