linux-kernel - Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <496842ea-a04f-431b-5eee-6ef6535375ee@redhat.com>
Date:   Fri, 2 Sep 2016 13:23:47 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Steve Wise <swise@...ngridcomputing.com>,
        "'Baoyou Xie'" <baoyou.xie@...aro.org>, sean.hefty@...el.com,
        hal.rosenstock@...il.com
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...aro.org, xie.baoyou@....com.cn
Subject: Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp

On 8/29/2016 10:26 AM, Steve Wise wrote:
>> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>>
>> We get 1 warning when build kernel with W=1:
>> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
>> '_free_qp' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
>> Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>
>> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> 
> Ignore my comment on v2...
> 
> Acked-by: Steve Wise <swise@...ngridcomputing.com>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
    GPG Key ID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)