linux-kernel - Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 02 Sep 2016 10:44:21 -0700
From:   Joe Perches <joe@...ches.com>
To:     Yuval Mintz <Yuval.Mintz@...gic.com>,
        kbuild test robot <fengguang.wu@...el.com>,
        David Miller <davem@...emloft.net>
Cc:     "kbuild-all@...org" <kbuild-all@...org>,
        netdev <netdev@...r.kernel.org>,
        Ariel Elior <Ariel.Elior@...gic.com>,
        Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@...gic.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>
Subject: Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

On Thu, 2016-09-01 at 07:37 +0000, Yuval Mintz wrote:
> > drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc
> > should be used for dcbx_info, instead of kmalloc/memset
> > drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc
> > should be used for dcbx_info, instead of kmalloc/memset
> > 
> >  Use kzalloc rather than kmalloc followed by memset with 0
[]
> One question the automated script -
> Can't it [relative] easily be upgraded to also have 'Fixes:' as part
> of its message?

It's really not a "fix" as it has no real effect on behavior.

The code is perfectly fine as is really.

It is a code size reduction though.

Another thing with a behavior change and one that would also
reduce code size would be to remove the unnecessary OOM
messages after the allocs.

I'll send a patch for that.