linux-kernel - Re: [PATCH 1/1] x86, relocs: add function attributes to die()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACbG309_Wa3QcYxCF6WEomEcDefaOjJdNiLqWdAYJgCup7kvvA@mail.gmail.com>
Date:   Sat, 3 Sep 2016 10:16:56 -0500
From:   Nilay Vaish <nilayvaish@...il.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86 <x86@...nel.org>,
        Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] x86, relocs: add function attributes to die()

On 3 September 2016 at 09:50, Nicolas Iooss <nicolas.iooss_linux@....org> wrote:
>
>     arch/x86/tools/relocs.c:460:5: error: format specifies type 'int'
>     but the argument has type 'Elf64_Xword' (aka 'unsigned long')
>     [-Werror,-Wformat]
>                                     sec->shdr.sh_size);
>                                     ^~~~~~~~~~~~~~~~~
>     arch/x86/tools/relocs.c:464:5: error: format specifies type 'int'
>     but the argument has type 'Elf64_Off' (aka 'unsigned long')
>     [-Werror,-Wformat]
>                                     sec->shdr.sh_offset, strerror(errno));
>                                     ^~~~~~~~~~~~~~~~~~~
>
> To support both 32-bit and 64-bit modes, add casts to long types and use
> %lu and %ld to format the numbers.
>

Nicolas,  should not just changing the format specifiers fix the
problem?  How do those type casts help?

--
Nilay