linux-kernel - Re: [PATCH 1/3] perf tools: Recognize hugetlb mapping as anon mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Sep 2016 10:55:48 -0500
From:   Nilay Vaish <nilayvaish@...il.com>
To:     Wang Nan <wangnan0@...wei.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Linux Kernel list <linux-kernel@...r.kernel.org>,
        lizefan@...wei.com, Hou Pengyang <houpengyang@...wei.com>,
        He Kuang <hekuang@...wei.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 1/3] perf tools: Recognize hugetlb mapping as anon mapping

On 2 September 2016 at 08:59, Wang Nan <wangnan0@...wei.com> wrote:
> Hugetlbfs mapping should be recognized as anon mapping so user has
> a chance to create /tmp/perf-<pid>.map file for symbol resolving. This
> patch utilizes MAP_HUGETLB to identify hugetlb mapping.
>
> After this patch, if perf is started before the program uses huge pages
> starting, perf is able to recognize hugetlb mapping as anon mapping.

Wang, everything in the patch series looks good to me.  Just a slight
change that I would suggest for the summary above:  replace "program
uses huge pages starting" with "program starts using huge pages".

--
Nilay