linux-kernel - Re: [PATCH] iio: imu: inv_mpu6050: inform the i2c mux core about how it is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a4804d5-3d92-fff0-e48e-beebfb8ba1e2@kernel.org>
Date:   Sat, 3 Sep 2016 17:30:45 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Peter Rosin <peda@...ntia.se>, linux-iio@...r.kernel.org
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        linux-kernel@...r.kernel.org,
        Crestez Dan Leonard <leonard.crestez@...el.com>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: inform the i2c mux core about how
 it is used

On 31/08/16 09:02, Peter Rosin wrote:
> The i2c mux core can then take appropriate action depending on if it is
> used for an actual i2c mux, or for an arbitrator or gate. In this case
> it is used as a gate.
> 
> This will make devicetree bindings simpler when they are eventually
> added.
> 
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> So, this depends on the i2c-mux-dt-3 branch [1] that Jonathan
> pulled to support the new mpu-3050 gyroscope driver. I had
> planned to submit this post 4.9-rc1, but since the iio tree
> got the prerequisite already, I'm sending it right away.
It's not there yet as the mpu-3050 has to go round again
for other reasons.  As such I haven't yet pulled your branch.
This patch isn't going to justify the pull on it's own.

I'll try and remember to pick it up when Linus gets back with
the final mpu-3050 and I pull your tree in.

If not give me a poke!

Jonathan
> 
> Cheers,
> Peter
> 
> [1] https://github.com/peda-r/i2c-mux.git i2c-mux-dt-3
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> index 19580d1db597..2c3f8964a3ea 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> @@ -126,7 +126,7 @@ static int inv_mpu_probe(struct i2c_client *client,
>  
>  	st = iio_priv(dev_get_drvdata(&client->dev));
>  	st->muxc = i2c_mux_alloc(client->adapter, &client->dev,
> -				 1, 0, I2C_MUX_LOCKED,
> +				 1, 0, I2C_MUX_LOCKED | I2C_MUX_GATE,
>  				 inv_mpu6050_select_bypass,
>  				 inv_mpu6050_deselect_bypass);
>  	if (!st->muxc) {
>