linux-kernel - Re: [PATCH 3/4] sparc: bpf_jit: Avoid assignment for "flen" if BPF JIT is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57CB0124.1040605@iogearbox.net>
Date:   Sat, 03 Sep 2016 18:58:12 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        sparclinux@...r.kernel.org,
        Adam Buchbinder <adam.buchbinder@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Rabin Vincent <rabin@....in>
CC:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH 3/4] sparc: bpf_jit: Avoid assignment for "flen" if BPF
 JIT is disabled

On 09/03/2016 06:40 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 3 Sep 2016 18:00:03 +0200
>
> Move the assignment for the local variable "flen" a bit at the beginning
> so that it will only be performed if BPF JIT is enabled for this function.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Why is that a particular issue (did you measure some improvement when
you say "fine-tuning" as per subject) ?

That's all not in critical path here by the way, same for patch 2.