linux-kernel - Re: [PATCH] drm: amdgpu: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd7107ed-be39-ae1b-6adf-a42b125e1a68@amd.com>
Date:   Sat, 3 Sep 2016 10:13:19 +0200
From:   Christian König <christian.koenig@....com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <alexander.deucher@....com>,
        <airlied@...ux.ie>, <Qingqing.Wang@....com>, <Jammy.Zhou@....com>,
        <samuel.li@....com>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...db.de>, <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm: amdgpu: add missing header dependencies

Am 03.09.2016 um 08:01 schrieb Baoyou Xie:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:113:6: warning: no previous prototype for 'amdgpu_pll_compute' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:38:10: warning: no previous prototype for 'cz_get_argument' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:302:5: warning: no previous prototype for 'cz_smu_start' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are declared in
> drivers/gpu/drm/amd/amdgpu/atombios_i2c.h
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.h
> drivers/gpu/drm/amd/amdgpu/cz_dpm.h
> drivers/gpu/drm/amd/amdgpu/vi_dpm.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Reviewed-by: Christian König <christian.koenig@....com>.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c   | 1 +
>   drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 1 +
>   drivers/gpu/drm/amd/amdgpu/cz_smc.c       | 2 ++
>   3 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
> index d153149..8e67c12 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
> @@ -25,6 +25,7 @@
>   #include "amdgpu.h"
>   #include "atom.h"
>   #include "atombios_encoders.h"
> +#include "amdgpu_pll.h"
>   #include <asm/div64.h>
>   #include <linux/gcd.h>
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
> index bc56c8a..b374653 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
> @@ -27,6 +27,7 @@
>   #include "amdgpu.h"
>   #include "atom.h"
>   #include "amdgpu_atombios.h"
> +#include "atombios_i2c.h"
>   
>   #define TARGET_HW_I2C_CLOCK 50
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
> index c80c2e9..95887e4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
> @@ -29,6 +29,8 @@
>   #include "cz_smumgr.h"
>   #include "smu_ucode_xfer_cz.h"
>   #include "amdgpu_ucode.h"
> +#include "cz_dpm.h"
> +#include "vi_dpm.h"
>   
>   #include "smu/smu_8_0_d.h"
>   #include "smu/smu_8_0_sh_mask.h"