linux-kernel - Re: [PATCH] drm: amdgpu: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Sep 2016 17:10:11 +0800
From:   Huang Rui <ray.huang@....com>
To:     Baoyou Xie <baoyou.xie@...aro.org>
CC:     <alexander.deucher@....com>, <christian.koenig@....com>,
        <airlied@...ux.ie>, <Rex.Zhu@....com>, <Jammy.Zhou@....com>,
        <elfring@...rs.sourceforge.net>, <Young.Yang@....com>,
        <airlied@...hat.com>, <Mykola.Lysenko@....com>,
        <dan.carpenter@...cle.com>, <David1.Zhou@....com>,
        <Monk.Liu@....com>, <Jerry.Zhang@....com>, <samuel.li@....com>,
        <tom.stdenis@....com>, <Flora.Cui@....com>,
        <JinHuiEric.Huang@....com>, <funfunctor@...klore1984.net>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...db.de>, <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm: amdgpu: mark symbols static where possible

On Sat, Sep 03, 2016 at 01:57:14PM +0800, Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for 'cz_send_msg_to_smc_async' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype for 'cz_write_smc_sram_dword' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/iceland_smc.c:124:6: warning: no previous prototype for 'iceland_start_smc' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3926:6: warning: no previous prototype for 'gfx_v8_0_rlc_stop' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:94:6: warning: no previous prototype for 'amdgpu_job_free_cb' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Thanks.

Acked-by: Huang Rui <ray.huang@....com>