linux-kernel - Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160903103520.3E62B62019@smtp.codeaurora.org>
Date:   Sat,  3 Sep 2016 10:35:20 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org,
        Javier Martinez Canillas <javier@....samsung.com>,
        Amitkumar Karwar <akarwar@...vell.com>, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        Nishant Sarmukadam <nishants@...vell.com>
Subject: Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Javier Martinez Canillas <javier@....samsung.com> wrote:
> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message
> is printed but the actual error is not propagated to the caller function.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

What's the conclusion with this patch? Should I drop it or take it?

(The discussion is available from the patchwork link in the signature.)

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9288169/