Date:   Mon, 05 Sep 2016 06:47:57 +0800
From:   Caesar Wang <wxt@...k-chips.com>
To:     Heiko Stuebner <heiko@...ech.de>
CC:     Caesar Wang <wxt@...k-chips.com>, mark.rutland@....com,
        huangtao@...k-chips.com, Xing Zheng <zhengxing@...k-chips.com>,
        devicetree@...r.kernel.org, Marc Zyngier <marc.zyngier@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Brian Norris <briannorris@...omium.org>,
        Will Deacon <will.deacon@....com>, dianders@...omium.org,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Rob Herring <robh+dt@...nel.org>,
        David Wu <david.wu@...k-chips.com>, cf@...k-chips.com,
        linux-rockchip@...ts.infradead.org,
        Jianqun Xu <jay.xu@...k-chips.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs


On 2016年09月05日 06:09, Heiko Stuebner wrote:
> Hi Caesar,
>
> Am Samstag, 3. September 2016, 08:13:17 CEST schrieb Caesar Wang:
>> Heiko,
>>
>> What do you think of it?
>> Maybe I need re-update these patches on next kernel, and re-test them.
> I checked linux-next and the underlying changes seem to all have gone in now,
> so we should be fine.
>
> Updating the patches would be cool. I tried applying them to my dts64 branch
> just now, but they don't apply cleanly anymore due to other changes going in
> before.
>
> When you check against linux-next, please take into account that there is no
> new linux-next since 20160825 and 20160905 is the next planned linux-next
> release (probably Stephen being on holiday).

I will update/resend them base on your v4.9-armsoc/dts64 branch. (Wait a 
moment to retest them)

Thanks.


>
>
> Thanks
> Heiko
>
>> On 2016年07月06日 16:05, Caesar Wang wrote:
>>> Hello Heiko, Marc & ARM guys
>>>
>>> When Jay first submitted the rk3399.dtsi upstream
>>> <https://patchwork.kernel.org/patch/8885821/> he had the PMU node in
>>> there,
>>> but then took it out because the upstream binding wasn't done yet.
>>> It looks as if the upstream stuff has landed, since in linux/master I see:
>>> 287e9357abcc DT/arm,gic-v3: Documment PPI partition support
>>> e3825ba1af3a irqchip/gic-v3: Add support for partitioned PPIs
>>> 9e2c986cb460 irqchip: Add per-cpu interrupt partitioning library
>>> 222df54fd8b7 genirq: Allow the affinity of a percpu interrupt to be
>>> set/retrieved 651e8b54abde irqdomain: Allow domain matching on irq_fwspec
>>>
>>> This series patches add to support the rk3399 SoCs PMU.
>>> I pick up the https://patchwork.kernel.org/patch/9209369/.
>>>
>>> As do some tests with ChromeOs for my rk3399 board.
>>> Tested with linus master 4.7-rc6 kernel on rk3399 board.
>>> https://github.com/Caesar-github/rockchip/tree/rk3399/pmu-upstream
>>>
>>> localhost / # perf list
>>>
>>> List of pre-defined events (to be used in -e):
>>> cpu-cycles OR cycles [Hardware event]
>>> instructions [Hardware event]
>>> cache-references [Hardware event]
>>> cache-misses [Hardware event]
>>> branch-instructions OR branches [Hardware event]
>>> branch-misses [Hardware event]
>>> bus-cycles [Hardware event]
>>> ...
>>>
>>> perf stat --cpu 0/1/2/3..... to minitor
>>> e.g. cpu0;
>>>
>>> localhost / # perf stat --cpu 0
>>>
>>> Performance counter stats for 'CPU(s) 0':
>>>
>>> 3374.917571 task-clock (msec) # 1.001 CPUs utilized [100.00%]
>>> 20 context-switches # 0.006 K/sec [100.00%]
>>> 2 cpu-migrations # 0.001 K/sec [100.00%]
>>> 55 page-faults # 0.016 K/sec
>>> 7151843 cycles # 0.002 GHz [100.00%]
>>> <not supported> stalled-cycles-frontend
>>> <not supported> stalled-cycles-backend
>>> 4272536 instructions # 0.60 insns per cycle [100.00%]
>>> 568406 branches # 0.168 M/sec [100.00%]
>>> 65652 branch-misses # 11.55% of all branches
>>>
>>> Also, 'perf top' to monitor the PMU interrupts from cpus
>>>
>>> -Caesar
>>>
>>>
>>> Changes in v2:
>>> - AS Mark comments on https://patchwork.kernel.org/patch/9209369/
>>>
>>>     remove the interrupt-affinity property, we need depend on Marc' perf
>>>     code on https://patchwork.kernel.org/patch/9209369/.
>>>
>>> Caesar Wang (2):
>>>     arm64: dts: rockchip: change all interrupts cells for 4 on rk3399 SoCs
>>>     arm64: dts: rockchip: support the pmu node for rk3399
>>>    
>>>    arch/arm64/boot/dts/rockchip/rk3399.dtsi | 118
>>>    ++++++++++++++++++------------- 1 file changed, 69 insertions(+), 49
>>>    deletions(-)
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
caesar wang | software engineer | wxt@...k-chip.com

Powered by blists - more mailing lists