linux-kernel - Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALRcH8B0T=ONm4C1ZBgCervZ+nrpd9OzoiBt7eXpnku4SDfNyA@mail.gmail.com>
Date:   Sun, 4 Sep 2016 14:32:32 +0530
From:   Amit Ghadge <amitg.b14@...il.com>
To:     Ian Abbott <abbotti@....co.uk>
Cc:     Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, Amit Ghadge <amitg.b14@...il.com>
Subject: Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use *
 on subsequent lines.

On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge <amitg.b14@...il.com> wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge <amitg.b14@...il.com>
> ---
>  drivers/staging/comedi/comedidev.h            |  8 ++---
>  drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +++++++++++++--------------
>  2 files changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index dcb6376..612a844 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
>  #define RANGE(a, b)            {(a) * 1e6, (b) * 1e6, 0}
>  #define RANGE_ext(a, b)                {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b)         {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_MA(a, b)         {(a) * 1e6, (b) * 1e6, UNIT_MA}
>  #define RANGE_unitless(a, b)   {(a) * 1e6, (b) * 1e6, 0}
>  #define BIP_RANGE(a)           {-(a) * 1e6, (a) * 1e6, 0}
>  #define UNI_RANGE(a)           {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
>  extern const struct comedi_lrange range_unipolar10;
>  extern const struct comedi_lrange range_unipolar5;
>  extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
>  extern const struct comedi_lrange range_unknown;
>
>  #define range_digital          range_unipolar5
> diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
> index d9de83a..ff3716c 100644
> --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
> +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
> @@ -1,35 +1,35 @@
>  /*
> -    comedi/drivers/ni_daq_dio24.c
> -    Driver for National Instruments PCMCIA DAQ-Card DIO-24
> -    Copyright (C) 2002 Daniel Vecino Castel <dvecino@...e.es>
> + * comedi/drivers/ni_daq_dio24.c
> + * Driver for National Instruments PCMCIA DAQ-Card DIO-24
> + * Copyright (C) 2002 Daniel Vecino Castel <dvecino@...e.es>
>
> -    PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
> -    2001/08/24 12:13:13 from the pcmcia package.
> -    The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
> -    <dahinds@...rs.sourceforge.net>.  Portions created by David A. Hinds
> -    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
> + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
> + * 2001/08/24 12:13:13 from the pcmcia package.
> + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
> + * <dahinds@...rs.sourceforge.net>.  Portions created by David A. Hinds
> + * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
>
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
>
> -    This program is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -    GNU General Public License for more details.
> -*/
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
>  /*
> -Driver: ni_daq_dio24
> -Description: National Instruments PCMCIA DAQ-Card DIO-24
> -Author: Daniel Vecino Castel <dvecino@...e.es>
> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
> -Status: ?
> -Updated: Thu, 07 Nov 2002 21:53:06 -0800
> + * Driver: ni_daq_dio24
> + * Description: National Instruments PCMCIA DAQ-Card DIO-24
> + * Author: Daniel Vecino Castel <dvecino@...e.es>
> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
> + * Status: ?
> + * Updated: Thu, 07 Nov 2002 21:53:06 -0800
>
> -This is just a wrapper around the 8255.o driver to properly handle
> -the PCMCIA interface.
> -*/
> + * This is just a wrapper around the 8255.o driver to properly handle
> + * the PCMCIA interface.
> + */
>
>  #include <linux/module.h>
>  #include "../comedi_pcmcia.h"
> --
> 2.5.5
>


Please ignore this patch.


Amit