linux-kernel - Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1609051101560.12528@pmeerw.net>
Date:   Mon, 5 Sep 2016 11:02:21 +0200 (CEST)
From:   Peter Meerwald-Stadler <pmeerw@...erw.net>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
cc:     thomas.petazzoni@...e-electrons.com, lars@...afoo.de,
        linux-iio@...r.kernel.org, antoine.tenart@...e-electrons.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        knaack.h@....de, maxime.ripard@...e-electrons.com, jic23@...nel.org
Subject: Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC


> >>>> +{
> >>>> +	return SUN6I_GPADC_CTRL1_ADC_CHAN_SELECT(chan);
> >>>> +}
> >>>> +
> >>>> +struct soc_specific {
> >>>> +	const int		temp_offset;
> >>>
> >>> wondering why you constify every member?
> >>>
> >>
> >> Because they're supposed to be fixed values? It won't change in runtime.
> >> Is there any reason why I shouldn't do that?
> > 
> > yes, but using the entire struct as const has the same effect;
> > constifying individual members makes more sense if there are also 
> > non-const members
> > 
> > nothing wrong, just unusual
> > 
> 
> So I would let all members non-const and then when using the struct
> soc_specific as a member in a struct or as a variable I would prefix it
> with const? That's what you mean by using the entire struct as const?

yes, exactly

thanks, p.

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)