linux-kernel - A potential bug in drivers/tty/serial/jsm/jsm.ko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <59b624dd-34b0-c130-77db-40db5802f03f@ispras.ru>
Date:   Mon, 5 Sep 2016 12:11:07 +0300
From:   Pavel Andrianov <andrianov@...ras.ru>
To:     Gabriel Krisman Bertazi <krisman@...ux.vnet.ibm.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vaishali Thakkar <vaishali.thakkar@...cle.com>,
        ldv-project@...uxtesting.org
Subject: A potential bug in drivers/tty/serial/jsm/jsm.ko

Hi!

There is a potential bug in drivers/tty/serial/jsm/jsm.ko.
In neo_parse_isr, line 764 a field ch->ch_flags is updated under 
spinlock protection. In neo_copy_data_from_uart_to_queue the same values 
are written to the field without any protection, as the function is 
always called without locks.
Should the same lock be used in these cases?
-- 
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@...ras.ru