linux-kernel - Re: [PATCH] lpfc: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 05 Sep 2016 13:14:26 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     james.smart@...gotech.com, dick.kennedy@...gotech.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] lpfc: mark symbols static where possible

On Sunday, September 4, 2016 3:07:27 PM CEST Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/scsi/lpfc/lpfc_sli.c:5693:1: warning: no previous prototype for 'lpfc_set_features' [-Wmissing-prototypes]
> drivers/scsi/lpfc/lpfc_sli.c:8972:1: warning: no previous prototype for 'lpfc_sli_calc_ring' [-Wmissing-prototypes]
> drivers/scsi/lpfc/lpfc_mbox.c:2264:1: warning: no previous prototype for 'lpfc_mbx_cmpl_rdp_link_stat' [-Wmissing-prototypes]
> ....
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 

Acked-by: Arnd Bergmann <arnd@...db.de>