linux-kernel - Re: [PATCH] power: avoid calling cancel_delayed_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jyZ2=T-F13dFuzX8bZrnnhVBkkvKuZTkfVpsTf83U=dg@mail.gmail.com>
Date:   Mon, 5 Sep 2016 14:58:29 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Tejun Heo <tj@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Wang Wilbur <wilburwang@...micro.com>,
        Wu Gang <gangwu@...micro.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        qiaozhou <qiaozhou@...micro.com>
Subject: Re: [PATCH] power: avoid calling cancel_delayed_work_sync() during
 early boot

On Mon, Sep 5, 2016 at 2:38 PM, Tejun Heo <tj@...nel.org> wrote:
> of_clk_init() ends up calling into pm_qos_update_request() very early
> during boot where irq is expected to stay disabled.
> pm_qos_update_request() uses cancel_delayed_work_sync() which
> correctly assumes that irq is enabled on invocation and
> unconditionally disables and re-enables it.
>
> Gate cancel_delayed_work_sync() invocation with kevented_up() to avoid
> enabling irq unexpectedly during early boot.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reported-and-tested-by: Qiao Zhou <qiaozhou@...micro.com>
> Link: http://lkml.kernel.org/r/d2501c4c-8e7b-bea3-1b01-000b36b5dfe9@asrmicro.com
> ---
>
> Rafael, can you please route this patch?

I will.

Thanks,
Rafael