linux-kernel - Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871t0z40ub.wl%kuninori.morimoto.gx@renesas.com>
Date:   Mon, 5 Sep 2016 01:09:15 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Khiem Nguyen <khiem.nguyen.xt@...esas.com>
CC:     Wolfram Sang <wsa@...-dreams.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <damm+renesas@...nsource.se>,
        "Zhang Rui" <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Thao Phuong Le. Nguyen" <thao.nguyen.yb@....renesas.com>,
        Hien Dang <hien.dang.eb@...esas.com>,
        Toru Oishi <toru.oishi.zj@...esas.com>
Subject: Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver


Hi

> Khiem Nguyen (5):
>  thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings
>  thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support
>  arm64: dts: r8a7795: Add R-Car Gen3 thermal support
>  arm64: dts: r8a7796: Add R-Car Gen3 thermal support
>  arm64: defconfig: Enable R-Car Gen3 thermal support

For all patches

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

> +static int rcar_gen3_thermal_get_temp(void *devdata, int *temp)
> +{
> +	struct rcar_gen3_thermal_priv *priv = devdata;
> +	int ctemp;
> +	unsigned long flags;
> +
> +	rcar_gen3_thermal_update_temp(priv);
> +
> +	spin_lock_irqsave(&priv->lock, flags);
> +	ctemp = _linear_temp_converter(priv->coef, priv->ctemp);
> +	spin_unlock_irqrestore(&priv->lock, flags);

This is not a big deal, but, as I mentioned in v1 patch,
having pointer for _linear_temp_converter() parameter is good idea.
	_linear_temp_converter(&priv->coef, xxx);

or
	_linear_temp_converter(priv);