linux-kernel - Re: [v2] bcma: use of_dma_configure() to set initial dma mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba2307b6-e139-0dfb-94c1-ea69548868b4@broadcom.com>
Date:   Mon, 5 Sep 2016 20:34:08 +0200
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Arnd Bergmann <arnd@...db.de>, Kalle Valo <kvalo@...eaurora.org>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v2] bcma: use of_dma_configure() to set initial dma mask



On 5-9-2016 17:26, Arnd Bergmann wrote:
> On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote:
>> Arnd Bergmann <arnd@...db.de> wrote:
>>> While fixing another bug, I noticed that bcma manually sets up
>>> a dma_mask pointer for its child devices. We have a generic
>>> helper for that now, which should be able to cope better with
>>> any variations that might be needed to deal with cache coherency,
>>> unusual DMA address offsets, iommus, or limited DMA masks, none
>>> of which are currently handled here.
>>>
>>> This changes the core to use the of_dma_configure(), like
>>> we do for platform devices that are probed directly from
>>> DT.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> Nobody tested this, so I'll drop the patch.
>>
> 
> Should I resend it? I think it's still required.

Maybe you should request some bcma users (Rafał?) explicitly to test
this. I have no equipment with CONFIG_OF enabled over here.

Regards,
Arend