linux-kernel - Re: [PATCH] staging: dgnc: Fix multi line comment alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Sep 2016 23:45:30 +0300
From:   Andrey Utkin <andrey_utkin@...tmail.com>
To:     Fernando Apesteguia <fernando.apesteguia@...il.com>
Cc:     lidza.louina@...il.com, gregkh@...uxfoundation.org,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: dgnc: Fix multi line comment alignment

On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> Fix alignment in multi line comment block.
> 
> Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
> 
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@...il.com>
> 
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index cc6105a..01e948c 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
>  	brd->re_map_membase = ioremap(brd->membase, 0x1000);
>  }
>  
> -/*****************************************************************************
> -*
> -* Function:
> -*
> -*    dgnc_poll_handler
> -*
> -* Author:
> -*
> -*    Scott H Kilau
> -*
> -* Parameters:
> -*
> -*    dummy -- ignored
> -*
> -* Return Values:
> -*
> -*    none
> -*
> -* Description:
> -*
> -*    As each timer expires, it determines (a) whether the "transmit"
> -*    waiter needs to be woken up, and (b) whether the poller needs to
> -*    be rescheduled.
> -*
> -******************************************************************************/
> +/*
> + *
> + * Function:
> + *
> + *    dgnc_poll_handler
> + *
> + * Author:
> + *
> + *    Scott H Kilau
> + *
> + * Parameters:
> + *
> + *    dummy -- ignored
> + *
> + * Return Values:
> + *
> + *    none
> + *
> + * Description:
> + *
> + *    As each timer expires, it determines (a) whether the "transmit"
> + *    waiter needs to be woken up, and (b) whether the poller needs to
> + *    be rescheduled.
> + *
> + */
>  
>  static void dgnc_poll_handler(ulong dummy)
>  {
> -- 
> 2.7.4

Changing first and last lines of that comment should be enough, but all
lines got changed. I'd (re)submit it with just first and last lines
changed.