linux-kernel - Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rza3U+X=cNXqvjB8fe1s+hP234cu405m3ObJBB=wQUcOQ@mail.gmail.com>
Date:   Mon, 5 Sep 2016 23:34:14 +0200
From:   Rafał Miłecki <zajec5@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask

On 17 March 2016 at 10:39, Arnd Bergmann <arnd@...db.de> wrote:
> While fixing another bug, I noticed that bcma manually sets up
> a dma_mask pointer for its child devices. We have a generic
> helper for that now, which should be able to cope better with
> any variations that might be needed to deal with cache coherency,
> unusual DMA address offsets, iommus, or limited DMA masks, none
> of which are currently handled here.
>
> This changes the core to use the of_dma_configure(), like
> we do for platform devices that are probed directly from
> DT.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I applied this patch and tested on BCM47081 based device. I still got
bgmac working which surely uses DMA. There is only 1 ARM wireless SoC
using bcma (BCM47198) but its WiFi core isn't supported by b43.

Any tips what else to test? SPI core/driver doesn't use DMA. Maybe
NAND core does, but we don't use it.

-- 
Rafał