linux-kernel - Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2016 07:38:34 +0800
From:   Ayaka <ayaka@...lik.info>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "John.Youn@...opsys.com" <John.Youn@...opsys.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "heiko@...ech.de" <heiko@...ech.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "kishon@...com" <kishon@...com>,
        "randy.li@...k-chips.com" <randy.li@...k-chips.com>
Subject: Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform



從我的 iPad 傳送

> David Laight <David.Laight@...LAB.COM> 於 2016年9月5日 下午9:35 寫道：
> 
> From: Randy Li
>> Sent: 03 September 2016 22:55
> ...
>> +            if (of_device_is_compatible(np, "rockchip,rk3288-usb")
>> +                    && (NULL != hsotg->phy->ops->reset))
>> +                hsotg->phy->ops->reset(hsotg->phy);
>> +
> 
> Is this the only place ops->reset() is called?
Yes.
> Probably much better to check it first.
Sure.
> 
>            if (hsotg->phy->ops->reset
>                    && of_device_is_compatible(np, "rockchip,rk3288-usb")
>                hsotg->phy->ops->reset(hsotg->phy);
I see, if there is no the other review request for this version, I would submit a new version to fix this problem tonight.
> 
>    David