linux-kernel - RE: [PATCH] usb: gadget: prevent potenial null pointer dereference on skb->len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB14551AC35EE907109BEC9B838BF90@VI1PR04MB1455.eurprd04.prod.outlook.com>
Date:   Tue, 6 Sep 2016 01:44:29 +0000
From:   Peter Chen <peter.chen@....com>
To:     Colin King <colin.king@...onical.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
        Nicholas Bellinger <nab@...ux-iscsi.org>,
        "Robert Baldyga" <r.baldyga@...sung.com>,
        John Youn <John.Youn@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: prevent potenial null pointer dereference on
 skb->len

 
>
>From: Colin Ian King <colin.king@...onical.com>
>
>An earlier fix partially fixed the null pointer dereference on skb->len by moving the
>assignment of len after the check on skb being non-null, however it failed to remove
>the erroneous dereference when assigning len.
>Correctly fix this by removing the initialisation of len as was originally intended.
>
>Fixes: 70237dc8efd092 ("usb: gadget: function: f_eem: socket buffer may be NULL")
>Signed-off-by: Colin Ian King <colin.king@...onical.com>
>---
> drivers/usb/gadget/function/f_eem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/usb/gadget/function/f_eem.c b/drivers/usb/gadget/function/f_eem.c
>index 8741fd7..007ec6e 100644
>--- a/drivers/usb/gadget/function/f_eem.c
>+++ b/drivers/usb/gadget/function/f_eem.c
>@@ -342,7 +342,7 @@ static struct sk_buff *eem_wrap(struct gether *port, struct
>sk_buff *skb)
> 	struct sk_buff	*skb2 = NULL;
> 	struct usb_ep	*in = port->in_ep;
> 	int		headroom, tailroom, padlen = 0;
>-	u16		len = skb->len;
>+	u16		len;
>
> 	if (!skb)
> 		return NULL;

Sorry, my careless, Thanks for fixing it.

Acked-by: Peter Chen <peter.chen@....com>

Peter