linux-kernel - Re: [PATCH] video: mxsfb: get supply regulator optionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8368040-bb5a-91e0-7511-df462719b949@ti.com>
Date:   Tue, 6 Sep 2016 11:21:33 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Stefan Agner <stefan@...er.ch>, <plagnioj@...osoft.com>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <devicetree@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] video: mxsfb: get supply regulator optionally

Hi,

On 04/09/16 07:26, Stefan Agner wrote:
> The lcd-supply is meant to be optional, there are several device-
> trees not specifying it and the code handles error values silently.
> Therefor, avoid creating a dummy regulator (and the associated
> warning) by using devm_regulator_get_optional.
> 
> While at it, document that fact also in the device-tree bindings.

The binding change looks correct, but using
devm_regulator_get_optional() does not sound correct.

devm_regulator_get_optional() is to be used when the device in question
truly can function without the power supply. But if the supply is there,
it's just not controlled by the SW, devm_regulator_get() is to be used.

At least this is my understanding.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)