linux-kernel - Re: [PATCH] [media] coda: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 06 Sep 2016 11:28:50 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH] [media] coda: add missing header dependencies

Am Dienstag, den 06.09.2016, 11:21 +0200 schrieb Arnd Bergmann:
> On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
> >  #include <linux/kernel.h>
> >  #include <linux/string.h>
> > +#include <coda.h>
> > 
> 
> by convention, we tend to write this as
> 
> #include "coda.h"
> 
> otherwise the patch looks good to me,
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>

Same here, make that

+
+#include "coda.h"

and feel free to add
Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

thanks
Philipp