linux-kernel - Re: [PATCH v2] ASoC: rockchip: i2s: restore register during runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160906102944.GH3950@sirena.org.uk>
Date:   Tue, 6 Sep 2016 11:29:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Sugar Zhang <sugar.zhang@...k-chips.com>
Cc:     dianders@...omium.org, linux-rockchip@...ts.infradead.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Heiko Stuebner <heiko@...ech.de>, alsa-devel@...a-project.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: rockchip: i2s: restore register during
 runtime_suspend/resume cycle

On Tue, Sep 06, 2016 at 09:19:53AM +0800, Sugar Zhang wrote:

>  	struct rk_i2s_dev *i2s = dev_get_drvdata(dev);
> -	int ret;
> +	int ret = 0;
>  

Why are you initializing this?  All this will do is stop the compiler
warning you about use without initializaiton bugs.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)