lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Sep 2016 14:17:43 +0200 From: Ulf Hansson <ulf.hansson@...aro.org> To: Baolin Wang <baolin.wang@...aro.org> Cc: Adrian Hunter <adrian.hunter@...el.com>, Russell King <rmk+kernel@....linux.org.uk>, Shawn Lin <shawn.lin@...k-chips.com>, Doug Anderson <dianders@...omium.org>, Heiko Stübner <heiko@...ech.de>, David Jander <david@...tonic.nl>, Hans de Goede <hdegoede@...hat.com>, linux-mmc <linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mark Brown <broonie@...nel.org>, Linus Walleij <linus.walleij@...aro.org> Subject: Re: [PATCH v4 1/3] mmc: core: Remove some redundant validations in mmc_erase() function On 6 September 2016 at 04:55, Baolin Wang <baolin.wang@...aro.org> wrote: > Before issuing mmc_erase() function, users always have checked if it can > erase with mmc_can_erase/trim/discard() function, thus remove the redundant > erase checking in mmc_erase() function. > > Signed-off-by: Baolin Wang <baolin.wang@...aro.org> > Tested-by: Shawn Lin <shawn.lin@...k-chips.com> > --- > Changes since v3: > - Split into 3 separate patches. > - Add test tag by Shawn. > > Changes since v2: > - Add nr checking and other optimization in mmc_erase() function. > > Changes since v1: > - Add the alignment if card->erase_size is not power of 2. > --- > drivers/mmc/core/core.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index e55cde6..7d7209d 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -2217,13 +2217,6 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr, > unsigned int rem, to = from + nr; > int err; > > - if (!(card->host->caps & MMC_CAP_ERASE) || > - !(card->csd.cmdclass & CCC_ERASE)) > - return -EOPNOTSUPP; > - > - if (!card->erase_size) > - return -EOPNOTSUPP; > - Could we postpone this until after a clean-up-series of the mmc erase functions? Until the function remains an exported API, I think it should keep doing this validations. > if (mmc_card_sd(card) && arg != MMC_ERASE_ARG) > return -EOPNOTSUPP; > > -- > 1.7.9.5 > Kind regards Uffe
Powered by blists - more mailing lists