linux-kernel - Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWujzjS9pDett3BT+xboS6DnhWmyF_hRQMJ2QUOJfPnjw@mail.gmail.com>
Date:   Tue, 6 Sep 2016 14:24:20 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Khiem Nguyen <khiem.nguyen.xt@...esas.com>
Cc:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <damm+renesas@...nsource.se>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Thao Phuong Le. Nguyen" <thao.nguyen.yb@....renesas.com>,
        Hien Dang <hien.dang.eb@...esas.com>,
        Toru Oishi <toru.oishi.zj@...esas.com>
Subject: Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

Hi Khiem,

On Tue, Sep 6, 2016 at 2:19 PM, Khiem Nguyen
<khiem.nguyen.xt@...esas.com> wrote:
>> > +static int rcar_gen3_thermal_probe(struct platform_device *pdev) {
>>
>> > +       priv->id = of_alias_get_id(dev->of_node, "tsc");
>> > +       if (priv->id < 0) {
>> > +               dev_err(dev, "Failed to get alias id (%d)\n", priv->id);
>> > +               ret = priv->id;
>> > +               goto error_unregister;
>> > +       }
>>
>> In v1, Morimoto-san wondered whether the alias is really needed, but you haven't
>> addressed his question.
>>
>> While aliases can be useful in DT source files, using aliases like this imposes
>> hardcoded instance numbers, which is something we try to avoid these days.
>> Also, this puts a hard requirement on the presence of the alias in DT, which should
>> be documented in the DT bindings.
>
> OK.
> I prefer updating DT binding to describe alias.
>
> There is requirement about coefficient to calculate temperature,
> and the coefficient value (fixed value) is different among thermal sensors.

>From DT, you can still refer to a specific instance using a phandle to a label.
You do not need aliases for that.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds