lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 06 Sep 2016 15:39:59 +0200 From: Arnd Bergmann <arnd@...db.de> To: David Howells <dhowells@...hat.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] rxrpc: remove duplicate 'error' variable On Tuesday, September 6, 2016 2:34:02 PM CEST David Howells wrote: > Arnd Bergmann <arnd@...db.de> wrote: > > > The rxrpc_process_call function has debug code to print a failure code, > > but instead of printing the code from the rxrpc_call structure, it > > prints an uninitialized variable: > > > > net/rxrpc/call_event.c: In function 'rxrpc_process_call': > > net/rxrpc/call_event.c:879:58: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > > > This removes the extraneous variable and prints the correct > > code instead. > > > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > > Fixes: f5c17aaeb2ae ("rxrpc: Calls should only have one terminal state") > > I've already posted a fix and it's waiting on DaveM. > > https://patchwork.ozlabs.org/patch/665550/ > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-rewrite&id=00b5407e427ac2588a2496b92035a94602b3cd1b Ok, good. At least I'm glad my patch is correct this time (being identical to yours). Arnd
Powered by blists - more mailing lists