linux-kernel - Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160906155030.01501417@bbrezillon>
Date:   Tue, 6 Sep 2016 15:50:30 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn, Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static

On Tue, 06 Sep 2016 15:43:45 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]
> > 
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> > 
> > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> >   
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>

Actually, Thierry already posted the same patch a while ago. I just
sent a PR to Dave containing this patch.