linux-kernel - Re: [PATCH] drivers/hwtracing: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2016 09:27:09 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, xie.baoyou@....com.cn
Subject: Re: [PATCH] drivers/hwtracing: add missing header dependencies

On 6 September 2016 at 01:56, Baoyou Xie <baoyou.xie@...aro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes]
>
> In fact, this function is declared in coresight-etm-perf.h, so this patch
> add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 755125f..d936e82 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -28,6 +28,7 @@
>  #include <linux/workqueue.h>
>
>  #include "coresight-priv.h"
> +#include "coresight-etm-perf.h"

I already fixed this one in my next branch -  it will show up in the 4.9 cycle.

Thanks for the submission,
Mathieu

>
>  static struct pmu etm_pmu;
>  static bool etm_perf_up;
> --
> 2.7.4
>