linux-kernel - [PATCH v3 3/6] staging: rtl8188eu: declare internal function as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  6 Sep 2016 18:36:54 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     devel@...verdev.osuosl.org
Cc:     Luca Ceresoli <luca@...aceresoli.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Geliang Tang <geliangtang@....com>,
        Jakub Sitnicki <jsitnicki@...il.com>,
        Ivan Safonov <insafonov@...il.com>,
        Kyle Kuffermann <kyle.kuffermann@...il.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH v3 3/6] staging: rtl8188eu: declare internal function as static

This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.

Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Geliang Tang <geliangtang@....com>
Cc: Jakub Sitnicki <jsitnicki@...il.com>
Cc: Ivan Safonov <insafonov@...il.com>
Cc: Kyle Kuffermann <kyle.kuffermann@...il.com>
Cc: devel@...verdev.osuosl.org
Cc: linux-kernel@...r.kernel.org

---

Changes v2 -> v3:
- add "staging: " prefix to commit message title.

Changes v1 -> v2:
- improve the commit message.
---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 977bb25..1063617 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -39,7 +39,7 @@ static u8 rtw_rfc1042_header[] = {
        0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };
 
-void rtw_signal_stat_timer_hdl(unsigned long data);
+static void rtw_signal_stat_timer_hdl(unsigned long data);
 
 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 {
@@ -2088,7 +2088,7 @@ _recv_entry_drop:
 	return ret;
 }
 
-void rtw_signal_stat_timer_hdl(unsigned long data)
+static void rtw_signal_stat_timer_hdl(unsigned long data)
 {
 	struct adapter *adapter = (struct adapter *)data;
 	struct recv_priv *recvpriv = &adapter->recvpriv;
-- 
2.7.4