linux-kernel - Re: [PATCH] jfs: Simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e6c449d-1b6e-b574-9849-07266c52ab83@oracle.com>
Date:   Tue, 6 Sep 2016 12:24:26 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        shaggy@...nel.org
Cc:     jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] jfs: Simplify code

On 09/03/2016 12:35 AM, Christophe JAILLET wrote:
> Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to
> 'list_splice_init'.

Looks good. I'll push this upstream.

> 
> This has been spotted with the following coccinelle script:
> /////
> @@
> expression y,z;
> @@
> 
> -   list_splice(y,z);
> -   INIT_LIST_HEAD(y);
> +   list_splice_init(y,z);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Signed-off-by: Dave Kleikamp <dave.kleikamp@...cle.com>

> ---
>  fs/jfs/jfs_txnmgr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index 2e58978d6f45..4d973524c887 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -2893,8 +2893,7 @@ restart:
>  	 * on anon_list2.  Let's check.
>  	 */
>  	if (!list_empty(&TxAnchor.anon_list2)) {
> -		list_splice(&TxAnchor.anon_list2, &TxAnchor.anon_list);
> -		INIT_LIST_HEAD(&TxAnchor.anon_list2);
> +		list_splice_init(&TxAnchor.anon_list2, &TxAnchor.anon_list);
>  		goto restart;
>  	}
>  	TXN_UNLOCK();
>