linux-kernel - Re: [PATCH RESEND] genirq: Machine-parsable version of /proc/interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEfhGixm_=sW8VheoNKZxnUOr3vbXCyATJsQEf=HxyNOW2SkgA@mail.gmail.com>
Date:   Tue, 6 Sep 2016 16:55:28 -0400
From:   Craig Gallek <kraigatgoog@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     David Decotigny <decot@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] genirq: Machine-parsable version of /proc/interrupts

On Fri, Sep 2, 2016 at 10:59 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Tue, 26 Jul 2016, Craig Gallek wrote:
>> +static void irq_kobj_release(struct kobject *kobj)
>> +{
>> +     struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
>> +
>> +     /*
>> +      * This irq_desc is statically allocated.  Simply zero its kobject
>> +      * rather than kfree it.
>> +      */
>> +     memset(&desc->kobj, 0, sizeof(desc->kobj));
>
> This will nicely explode when the irq descriptor is handed out again before
> this function is called.
>
> There is no point to make this work for !SPARSE_IRQ. Just ignore it.
Thank you for the review.  Just one clarification before I send v2:
Are you suggesting getting rid of this feature entirely for the
non-sparse version or just this kobject cleanup code?