linux-kernel - Re: [PATCH 4/4 v2] drm/bridge: adv7511: Initialize audio packet on adv7533

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLUeG5ptX_FdVeVps75Z=6J2N63Fu9ycxtpzmaxR1712Mw@mail.gmail.com>
Date:   Tue, 6 Sep 2016 15:58:25 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Archit Taneja <architt@...eaurora.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Andy Green <andy.green@...aro.org>,
        David Airlie <airlied@...ux.ie>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Andy Green <andy@...mcat.com>,
        Dave Long <dave.long@...aro.org>,
        Guodong Xu <guodong.xu@...aro.org>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jose Abreu <joabreu@...opsys.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 4/4 v2] drm/bridge: adv7511: Initialize audio packet on adv7533

On Fri, Sep 2, 2016 at 2:49 AM, Archit Taneja <architt@...eaurora.org> wrote:
> Hi,
>
>
> On 8/30/2016 5:11 AM, John Stultz wrote:
>>
>> From: Andy Green <andy.green@...aro.org>
>>
>> Set the initial audio packet settings to allow the audio
>> driver to work.
>>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Archit Taneja <architt@...eaurora.org>
>> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>> Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> Cc: "Ville Syrjälä" <ville.syrjala@...ux.intel.com>
>> Cc: Boris Brezillon <boris.brezillon@...e-electrons.com>
>> Cc: Andy Green <andy@...mcat.com>
>> Cc: Dave Long <dave.long@...aro.org>
>> Cc: Guodong Xu <guodong.xu@...aro.org>
>> Cc: Zhangfei Gao <zhangfei.gao@...aro.org>
>> Cc: Mark Brown <broonie@...nel.org>
>> Cc: Lars-Peter Clausen <lars@...afoo.de>
>> Cc: Jose Abreu <joabreu@...opsys.com>
>> Cc: dri-devel@...ts.freedesktop.org
>> Signed-off-by: Andy Green <andy.green@...aro.org>
>> [jstultz: Forward ported to mainline, changed to use register
>>   names rather then hex values, and removed config values set by
>>   audio driver.]
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>> ---
>>   drivers/gpu/drm/bridge/adv7511/adv7533.c | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c
>> b/drivers/gpu/drm/bridge/adv7511/adv7533.c
>> index 6798ecf..cced7c9 100644
>> --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
>> +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
>> @@ -104,6 +104,28 @@ void adv7533_dsi_power_on(struct adv7511 *adv)
>>         /* disable test mode */
>>         regmap_write(adv->regmap_cec, 0x55, 0x00);
>>
>> +       /* hide Audio infoframe updates */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_INFOFRAME_UPDATE,
>> +                               BIT(5), BIT(5));
>> +       /* enable N/CTS, enable Audio sample packets */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1,
>> +                               BIT(5), BIT(5));
>> +       /* enable N/CTS */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1,
>> +                               BIT(6), BIT(6));
>> +       /* not copyrighted */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_AUDIO_CFG1,
>> +                               BIT(5), BIT(5));
>> +       /* enable audio infoframes */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1,
>> +                               BIT(3), BIT(3));
>> +       /* AV mute disable */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_GC(0),
>> +                               BIT(7) | BIT(6), BIT(7));
>> +       /* use Audio infoframe updated info */
>> +       regmap_update_bits(adv->regmap, ADV7511_REG_GC(1),
>> +                               BIT(5), 0);
>> +
>
>
> Wouldn't these writes be needed by ADV751x chips too? These seem to
> belong to the main ADV75xx regmap. These should probably be a separate func
> in adv7511_audio.c or adv7511_drv.c, and it should be called in
> adv7511_power_on, so that ADV751x chips can utilize this too.

Yea. It seems like folding this into the audio_startup() function is
the best thing here, so I've done so and it seems to be working well.
Will resend here shortly.

thanks
-john