linux-kernel - Re: [PATCH] net: hns: declare function as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 06 Sep 2016 16:20:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wangkefeng.wang@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        yisen.zhuang@...wei.com, yankejian@...wei.com
Subject: Re: [PATCH] net: hns: declare function as static

From: Kefeng Wang <wangkefeng.wang@...wei.com>
Date: Tue, 6 Sep 2016 19:53:11 +0800

> Declare function as static to kill warning about missing-prototypes.
> 
> Cc: Yisen Zhuang <yisen.zhuang@...wei.com>
> Cc: Kejian Yan <yankejian@...wei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
 ...
> @@ -73,7 +73,7 @@ static struct ring_pair_cb *hns_ae_get_ring_pair(struct hnae_queue *q)
>  	return container_of(q, struct ring_pair_cb, q);
>  }
>  
> -struct hnae_handle *hns_ae_get_handle(struct hnae_ae_dev *dev,
> +static struct hnae_handle *hns_ae_get_handle(struct hnae_ae_dev *dev,
>  				      u32 port_id)

You have to adjust the indentation of the arguments on the following lines
if you change where the openning parenthesis is.  They must start exactly
at the column folling that openning parenthesis.