linux-kernel - Re: [PATCH] dmaengine: k3dma: use correct format string for debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160907081251.GW9355@localhost>
Date:   Wed, 7 Sep 2016 13:42:52 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Andy Green <andy.green@...aro.org>,
        Peter Griffin <peter.griffin@...aro.org>,
        Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: k3dma: use correct format string for debug
 output

On Tue, Sep 06, 2016 at 03:17:49PM +0200, Arnd Bergmann wrote:
> The newly added k3_dma_prep_dma_cyclic function has some debug output
> that uses incorrect typecasts, some of which cause a warning like:
> 
> drivers/dma/k3dma.c: In function 'k3_dma_prep_dma_cyclic':
> drivers/dma/k3dma.c:589:671: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 
> In general, we have to print 'dma_addr_t' values using special
> '%pad' format to get the correct behavior on kernels that have
> a 64-bit dma_addr_t type but 32-bit pointers.
> 
> Similarly, printing size_t values should be done using the %z
> modifier to get the correct behavior on 64-bit kernels.

Applied both, thanks


-- 
~Vinod