linux-kernel - Re: [PATCH] video: fbdev: intelfb: remove impossible condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2016 11:16:57 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Maik Broemme <mbroemme@...sserver.de>,
        Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: intelfb: remove impossible condition

On 31/08/16 18:44, Sudip Mukherjee wrote:
> xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
> they can never be less than 0.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> ---
>  drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
> index bf20744..ff2a5d2 100644
> --- a/drivers/video/fbdev/intelfb/intelfbdrv.c
> +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
> @@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,
>  		break;
>  	}
>  
> -	if (v.xoffset < 0)
> -		v.xoffset = 0;
> -	if (v.yoffset < 0)
> -		v.yoffset = 0;
> -
>  	if (v.xoffset > v.xres_virtual - v.xres)
>  		v.xoffset = v.xres_virtual - v.xres;
>  	if (v.yoffset > v.yres_virtual - v.yres)
> 

Thanks, queued for 4.9.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)