linux-kernel - Re: [PATCH 0/8] Qualcomm video decoder/encoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2016 11:57:19 +0300
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 0/8] Qualcomm video decoder/encoder driver

Hi Hans,

On 09/05/2016 05:47 PM, Hans Verkuil wrote:
> On 08/22/2016 03:13 PM, Stanimir Varbanov wrote:
>> This patchset introduces a basic support for Qualcomm video
>> acceleration hardware used for video stream decoding/encoding.
>> The video IP can found on various qcom SoCs like apq8084, msm8916
>> and msm8996, hence it is widly distributed but the driver is 
>> missing in the mainline.
>>
>> The v4l2 driver is something like a wrapper over Host Firmware
>> Interface. The HFI itself is a set of command and message packets
>> send/received through shared memory, and its purpose is to
>> comunicate with the firmware which is run on remote processor.
>> The Venus is the name of the video hardware IP that doing the
>> video acceleration.
>>
>> From the software point of view the HFI interface is implemented
>> in the files with prefix hfi_xxx. It acts as a translation layer
>> between HFI and v4l2 layer. There is one special file in the 
>> driver called hfi_venus which doing most of the driver
>> orchestration work. Something more it setups Venus core, run it
>> and handle commands and messages from low-level point of view with
>> the help of provided functions by HFI interface.
>>
>> I think that the driver is in good shape for mainline kernel, and
>> I hope the review comments will help to improve it, so please
>> do review and make comments.
> 
> I was hoping that I could finish reviewing this patch series today,
> but that didn't work out.
> 
> I have more time next week, but I wonder if it isn't better if you make a
> v2 first, taking my comments into account. Then I can review v2 next week.

OK, I have more of your comments addressed plus few of Bjorn's too.

> 
> Also test with the latest v4l2-compliance (i.e. as of today) since I improved
> a few tests relating to g/s_selection and g/s_parm.

Sure, I will retest and post the results in cover letter.

-- 
regards,
Stan