linux-kernel - RE: [PATCH 3/4] drm/fsl-dcu: update all registers on flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0401MB263147AB1A6915CABE6A04ACECF80@DB6PR0401MB2631.eurprd04.prod.outlook.com>
Date:   Wed, 7 Sep 2016 08:46:32 +0000
From:   Meng Yi <meng.yi@....com>
To:     Stefan Agner <stefan@...er.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
CC:     "alison.wang@...escale.com" <alison.wang@...escale.com>,
        "jianwei.wang.chn@...il.com" <jianwei.wang.chn@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/4] drm/fsl-dcu: update all registers on flush

Hi Stefan,

Some comments below

> 
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-
> dcu/fsl_dcu_drm_crtc.c
> index d30b61e..62eb284 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> @@ -27,6 +27,9 @@ static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc
> *crtc,  {
>  	struct drm_pending_vblank_event *event = crtc->state->event;
> 
> +	regmap_write(fsl_dev->regmap,
> +		     DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG);

fsl_dev is not declared.
I had added these two lines when testing the patches.

       struct drm_device *dev = crtc->dev;
       struct fsl_dcu_drm_device *fsl_dev = dev->dev_private;

> +
>  	if (event) {
>  		crtc->state->event = NULL;
> 

Best Regards,
Meng