linux-kernel - Re: [PATCH v2] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160907014155.GB3907@linux-zmni.apac.novell.com>
Date:   Wed, 7 Sep 2016 09:41:56 +0800
From:   Sean Fu <fxinrong@...il.com>
To:     Zhao Lei <zhaolei@...fujitsu.com>
Cc:     dsterba@...e.com, clm@...com, anand.jain@...cle.com,
        fdmanana@...e.com, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v2] Btrfs: remove unnecessary code of chunk_root
 assignment in btrfs_read_chunk_tree.

On Tue, Sep 06, 2016 at 01:19:39PM +0800, Zhao Lei wrote:
> Hi, Sean Fu
> 
> > -----Original Message-----
> > From: Sean Fu [mailto:fxinrong@...il.com]
> > Sent: Tuesday, September 06, 2016 11:51 AM
> > To: dsterba@...e.com
> > Cc: clm@...com; anand.jain@...cle.com; fdmanana@...e.com;
> > zhaolei@...fujitsu.com; linux-kernel@...r.kernel.org;
> > linux-btrfs@...r.kernel.org; Sean Fu <fxinrong@...il.com>
> > Subject: [PATCH v2] Btrfs: remove unnecessary code of chunk_root assignment
> > in btrfs_read_chunk_tree.
> > 
> > The input argument root is already set with "fs_info->chunk_root".
> > "chunk_root = fs_info->chunk_root = btrfs_alloc_root(fs_info)" in caller
> > "open_ctree".
> > "root->fs_info = fs_info” in "btrfs_alloc_root".
> > 
> > Signed-off-by: Sean Fu <fxinrong@...il.com>
> > ---
> > Changes in v2:
> >   - Renaming root to chunk_root to make it clear.
> > 
> >  fs/btrfs/volumes.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> > index 366b335..eb3d04a 100644
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -6591,7 +6591,7 @@ out_short_read:
> >  	return -EIO;
> >  }
> > 
> > -int btrfs_read_chunk_tree(struct btrfs_root *root)
> > +int btrfs_read_chunk_tree(struct btrfs_root *chunk_root)
> 
> Maybe you also need to modify function body to make it
> pass compile, and the header file also need to be modified.
Sorry for my mistake. I have released v3 for it.
> 
> BTW, Qu Wenruo give us a better way in reply, we
> can use fs_info directly.
Sorry, I don't know why we should use fs_info directly.
I have asked Qu for more detail.
Thanks for your review.
> 
> Thanks
> Zhaolei
> 
> >  {
> >  	struct btrfs_path *path;
> >  	struct extent_buffer *leaf;
> > @@ -6600,8 +6600,6 @@ int btrfs_read_chunk_tree(struct btrfs_root *root)
> >  	int ret;
> >  	int slot;
> > 
> > -	root = root->fs_info->chunk_root;
> > -
> >  	path = btrfs_alloc_path();
> >  	if (!path)
> >  		return -ENOMEM;
> > --
> > 2.6.2
> > 
> 
> 
> 
>