linux-kernel - Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877faokmzi.fsf@linux.intel.com>
Date:   Wed, 07 Sep 2016 13:44:49 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Romain Izard <romain.izard.pro@...il.com>,
        linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Romain Izard <romain.izard.pro@...il.com>
Subject: Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug

Romain Izard <romain.izard.pro@...il.com> writes:

> 2016-08-29 11:07 GMT+02:00 Romain Izard <romain.izard.pro@...il.com>:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as debug, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>
>> ---
>> v1 -> v2:
>> - use dev_dbg instead of dev_info
>>
>>  drivers/usb/gadget/configfs.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index f9237fe2be05..3984787f8e97 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>>                         list_move_tail(&f->list, &cfg->func_list);
>>                         if (f->unbind) {
>> -                               dev_err(&gi->cdev.gadget->dev, "unbind function"
>> -                                               " '%s'/%p\n", f->name, f);
>> +                               dev_dbg(&gi->cdev.gadget->dev,
>> +                                        "unbind function '%s'/%p\n",
>> +                                        f->name, f);
>>                                 f->unbind(c, f);
>>                         }
>>                 }
>> --
>> 2.7.4
>>
>
> Ping ?

https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=da7b895d518cc1753ee5f4b7f2158087282d1a65

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)