linux-kernel - Re: x86-ksysfs: Use kmalloc_array() in create_setup_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3eea073a-b271-54b7-1eec-e841e0f4bdf9@redhat.com>
Date:   Wed, 7 Sep 2016 13:20:18 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Kees Cook <keescook@...omium.org>, Ingo Molnar <mingo@...hat.com>,
        "x86@...nel.org" <x86@...nel.org>, Dave Young <dyoung@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Matt Fleming <matt.fleming@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()



On 07/09/2016 13:17, SF Markus Elfring wrote:
>>> Are you looking for further possibilities to improve the involved
>>> source code search patterns?
>>
>> Why are you not answering the simple question that was asked?
> 
> I find that I answered it to some degree.
> 
> It can be that you do not really like the kind of answer that I chose
> a moment ago.
> But I guess that a more pleasing (and complete) answer can become
> another software development challenge as you might know already.
> 
> Would the following script (for the semantic patch language)
> be useful enough for further development considerations?
> 
> usage_of_kmalloc_array1-excerpt2.cocci:
> @replacement2@
> expression count, pointer, target;
> @@
>  target =
> -         kmalloc(sizeof(*pointer) * (count)
> +         kmalloc_array(count, sizeof(*pointer)
>                         , ...);

Why don't you include the _exact_ script that you run?  That's the only
possible correct answer.

Paolo