linux-kernel - Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160907015219.4bk5ptcfyrosowwi@wfg-t540p.sh.intel.com>
Date:   Wed, 7 Sep 2016 09:52:19 +0800
From:   Fengguang Wu <lkp@...el.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     chengang@...ndsoft.com.cn, kbuild-all@...org, minchan@...nel.org,
        vbabka@...e.cz, gi-oh.kim@...fitbricks.com, iamjoonsoo.kim@....com,
        hillf.zj@...baba-inc.com, mgorman@...hsingularity.net,
        mhocko@...e.com, rientjes@...gle.com, linux-kernel@...r.kernel.org,
        rth@...ddle.net, ink@...assic.park.msu.ru, mattst88@...il.com,
        vgupta@...opsys.com, linux@...linux.org.uk,
        catalin.marinas@....com, will.deacon@....com,
        hskinnemoen@...il.com, egtvedt@...fundet.no, realmz6@...il.com,
        ysato@...rs.sourceforge.jp, rkuo@...eaurora.org,
        tony.luck@...el.com, fenghua.yu@...el.com, geert@...ux-m68k.org,
        james.hogan@...tec.com, ralf@...ux-mips.org, dhowells@...hat.com,
        deller@....de, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, dalias@...c.org, davem@...emloft.net,
        cmetcalf@...lanox.com, chris@...kel.net, jcmvbkbc@...il.com,
        arnd@...db.de, noamc@...hip.com, brueckner@...ux.vnet.ibm.com,
        mingo@...nel.org, peterz@...radead.org, linux-arch@...r.kernel.org,
        Chen Gang <gang.chen.5i5j@...il.com>
Subject: Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of
 int for all bit test functions

Hi Andrew,

On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote:
>On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@...el.com> wrote:
>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.8-rc4 next-20160825]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>
>> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
>> config: s390-default_defconfig (attached as .config)
>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=s390
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from include/linux/bitops.h:36:0,
>>                     from fs/btrfs/extent_io.c:1:
>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>>     static inline bool
>>                   ^
>>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>>     static inline bool
>
>My s390 cross compiler doesn't like that config.  Can someone test this?

Tested-by: Fengguang Wu <fengguang.wu@...el.com>

It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc:

https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz

>--- a/arch/s390/include/asm/bitops.h~a
>+++ a/arch/s390/include/asm/bitops.h
>@@ -40,6 +40,7 @@
> #error only <linux/bitops.h> can be included directly
> #endif
>
>+#include <linux/types.h>
> #include <linux/typecheck.h>
> #include <linux/compiler.h>
> #include <asm/barrier.h>

Regards,
Fengguang