linux-kernel - Re: [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI domain handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g47TJvQLPfUHwZV2EQDw2Tgu9mz1ajf9tWVoaMTXJiTw@mail.gmail.com>
Date:   Wed, 7 Sep 2016 13:32:36 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Tomasz Nowicki <tn@...ihalf.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <marc.zyngier@....com>,
        Jason Cooper <jason@...edaemon.net>,
        Bjorn Helgaas <helgaas@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
        Will Deacon <will.deacon@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Hanjun Guo <hanjun.guo@...aro.org>, shijie.huang@....com,
        robert.richter@...iumnetworks.com, Marcin Wojtas <mw@...ihalf.com>,
        Linux PCI <linux-pci@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>,
        Andrea Gallo <andrea.gallo@...aro.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Al Stone <al.stone@...aro.org>,
        G Gregory <graeme.gregory@...aro.org>,
        David Daney <ddaney.cavm@...il.com>,
        Sinan Kaya <okaya@...eaurora.org>
Subject: Re: [PATCH V10 2/8] ACPI: Add new IORT functions to support MSI
 domain handling

On Wed, Sep 7, 2016 at 12:35 PM, Tomasz Nowicki <tn@...ihalf.com> wrote:
> Rafael,
>
> There are two fixes for iort.c:
> 1. patch 1 - convert switch to if-else in iort_match_node_callback()
> 2. patch 2 - remove static local variable for iort_get_device_domain()
>
> Do you want me to repost these patches to get your ACK, or you want new V11?

Please repost the patches with changes (mark the new versions by
adding "[Update]" to the subject line or similar).

Thanks,
Rafael


> On 06.09.2016 12:27, Tomasz Nowicki wrote:
>>
>> On 06.09.2016 12:20, Thomas Gleixner wrote:
>>>
>>> On Tue, 6 Sep 2016, Tomasz Nowicki wrote:
>>>>
>>>> +/**
>>>> + * iort_get_device_domain() - Find MSI domain related to a device
>>>> + * @dev: The device.
>>>> + * @req_id: Requester ID for the device.
>>>> + *
>>>> + * Returns: the MSI domain for this device, NULL otherwise
>>>> + */
>>>> +struct irq_domain *iort_get_device_domain(struct device *dev, u32
>>>> req_id)
>>>> +{
>>>> +    static struct fwnode_handle *handle;
>>>
>>>
>>> static ??????
>>>
>>>> +    int its_id;
>>>> +
>>>> +    if (iort_dev_find_its_id(dev, req_id, 0, &its_id))
>>>> +        return NULL;
>>>> +
>>>> +    handle = iort_find_domain_token(its_id);
>>>
>>>
>>> You reevaluate that on every call.
>>>
>>
>> Obviously it is the bug. Thanks for spotting this.
>>
>> Tomasz