linux-kernel - Re: [PATCH] rtc: Add some dummy static inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160907121234.wrmxikrkrnw6lm7z@piout.net>
Date:   Wed, 7 Sep 2016 14:12:34 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     a.zummo@...ertech.it, rostedt@...dmis.org, mingo@...hat.com,
        john.stultz@...aro.org, tglx@...utronix.de, broonie@...nel.org,
        linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH] rtc: Add some dummy static inline functions

On 07/09/2016 at 15:17:26 +0800, Baolin Wang wrote :
> Add some dummy static inline functions in case CONFIG_RTC_LIB is not defined.
> 

The question your commit log should answer is why?

> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> Fixes: a0a6e06d545a ("time: alarmtimer: Add tracepoints for alarmtimers")
> ---
>  include/linux/rtc.h |   49 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/rtc.h b/include/linux/rtc.h
> index b693ada..521f752 100644
> --- a/include/linux/rtc.h
> +++ b/include/linux/rtc.h
> @@ -16,13 +16,60 @@
>  #include <linux/interrupt.h>
>  #include <uapi/linux/rtc.h>
>  
> +#ifdef CONFIG_RTC_LIB
>  extern int rtc_month_days(unsigned int month, unsigned int year);
> -extern int rtc_year_days(unsigned int day, unsigned int month, unsigned int year);
> +extern int rtc_year_days(unsigned int day, unsigned int month,
> +			 unsigned int year);
>  extern int rtc_valid_tm(struct rtc_time *tm);
>  extern time64_t rtc_tm_to_time64(struct rtc_time *tm);
>  extern void rtc_time64_to_tm(time64_t time, struct rtc_time *tm);
>  ktime_t rtc_tm_to_ktime(struct rtc_time tm);
>  struct rtc_time rtc_ktime_to_tm(ktime_t kt);
> +#else
> +static inline int rtc_month_days(unsigned int month, unsigned int year)
> +{
> +	return 0;
> +}
> +
> +static inline int rtc_year_days(unsigned int day, unsigned int month,
> +				unsigned int year)
> +{
> +	return 0;
> +}
> +
> +static inline int rtc_valid_tm(struct rtc_time *tm)
> +{
> +	return 0;
> +}
> +
> +static inline time64_t rtc_tm_to_time64(struct rtc_time *tm)
> +{
> +	time64_t ret;
> +
> +	memset(&ret, 0, sizeof(time64_t));
> +	return ret;
> +}
> +
> +static inline void rtc_time64_to_tm(time64_t time, struct rtc_time *tm)
> +{
> +}
> +
> +static inline ktime_t rtc_tm_to_ktime(struct rtc_time tm)
> +{
> +	ktime_t ret;
> +
> +	memset(&ret, 0, sizeof(ktime_t));
> +	return ret;
> +}
> +
> +static inline struct rtc_time rtc_ktime_to_tm(ktime_t kt)
> +{
> +	struct rtc_time ret;
> +
> +	memset(&ret, 0, sizeof(struct rtc_time));
> +	return ret;
> +}
> +#endif
>  
>  /*
>   * rtc_tm_sub - Return the difference in seconds.
> -- 
> 1.7.9.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com