linux-kernel - Re: [patch] leds: add driver for Mellanox systems leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160907125903.GA8088@nanopsycho>
Date:   Wed, 7 Sep 2016 14:59:03 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:     vadimp@...lanox.com, rpurdie@...ys.net, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, michaelsh@...lanox.com
Subject: Re: [patch] leds: add driver for Mellanox systems leds

Wed, Sep 07, 2016 at 02:49:00PM CEST, j.anaszewski@...sung.com wrote:
>Hi Vadim,
>
>On 09/07/2016 03:35 PM, vadimp@...lanox.com wrote:
>> From: Vadim Pasternak <vadimp@...lanox.com>
>> 
>> This makes it possible to create a set of LEDs for Mellanox systems:
>> "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
>> "msb7800", "msn2740", "msn2100".
>> 
>> Driver obtains led devices according to system configuration, provided
>> through system DMI data, like fan1:green, fan1:red and creates devices in
>> form: "devicename:colour:function".
>> 
>> led setting is controlled through on board CPLD Lattice device.
>> For setting particular led off, solid,
>> blink (blink requires ledtrig-timer module):
>> echo 0 > /sys/class/leds/status\:green/brightness
>> echo 1 > /sys/class/leds/status\:green/brightness
>> echo timer > /sys/class/leds/status\:green/trigger
>> 
>
>Thanks for the update, will review it soon.
>
>One important detail - please update patch version each time
>you're sending a new one, like [PATCH v2].

Also a brief history of changes made would help.


>
>-- 
>Best regards,
>Jacek Anaszewski