linux-kernel - Re: [GIT PULL] usercopy fixes for v4.8-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzY02zMvOKTwXn1tPtrjX4ujFjYL+SGFBPwNuCw_KsESQ@mail.gmail.com>
Date:   Wed, 7 Sep 2016 09:33:53 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [GIT PULL] usercopy fixes for v4.8-rc6

Pulled, but:

On Tue, Sep 6, 2016 at 12:37 PM, Kees Cook <keescook@...omium.org> wrote:
>
> Kees Cook (3):
>       usercopy: fold builtin_const check into inline function

Hmm. So with this, check_object_size() seems sane, but it's only
marked "inline".

And we've had the issue that without the __always_inline, gcc will
randomly not inline things. In fact, this very pull added that to the
copy_xyz_user() functions exactly because of this issue.

Now, it may be that check_object_size() is so simple that it really
always *will* be inlined regardless, but it looks a bit dodgy.

                   Linus