linux-kernel - RE: [PATCH] [SCSI] aacraid: mark aac_src_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423FD6710FB8FB4F8728F93591889F9A15FAB7E4@avsrvexchmbx1.microsemi.net>
Date:   Wed, 7 Sep 2016 18:03:59 +0000
From:   David Carroll <david.carroll@...rosemi.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "xie.baoyou@....com.cn" <xie.baoyou@....com.cn>
Subject: RE: [PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

> 
> We get 1 warning when building kernel with W=1:
> drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for
> 'aac_src_select_comm' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared and don't need
> a declaration, but can be made static.
> so this patch marks this function with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/scsi/aacraid/src.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Dave Carroll <david.carroll@...rosemi.com>