linux-kernel - Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFy5diabeoM38rx2VFiYrizf7Mk9bwma31o+1uHQFm95AQ@mail.gmail.com>
Date:   Wed, 7 Sep 2016 12:15:52 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Vinson Lee <vlee@...edesktop.org>
Subject: Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2

On Wed, Sep 7, 2016 at 11:36 AM, Kees Cook <keescook@...omium.org> wrote:
>
> - move page-spanning check behind a CONFIG since it's triggering false positives

Hmm. I pulled this, but looking at it I realized that

+       depends on !COMPILE_TEST

doesn't make any real sense to me.

All it does is make sure that "make allmodconfig" doesn't actually
test that the PAGESPAN code compiles.

It's not like that is a big cost for allmodconfig builds, but it does
mean that it gets less coverage.

And it really makes no sense to me. We *don't* want to run with that
option enabled normally.

I think what you actually meant was something like

+       depends on EXPERT

which means that it does *not* get enabled in normal user builds.

Hmm?

                  Linus